You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several problems with this implementation:
The implementation does not follow the sorting paradigm in the other pages of providing a "Reset sorting" link to clear the current sort. This means that once a user selects a field to sort, they can't sort exclusively on another field – the sort for the first field is always taken into account. The only way to clear the sort is to reset the page by selecting the "Reports" entry from the dropdown menu (or clearing the sort params from the URL in the address bar).
The fields do not display the up/down sort arrows by default as on other pages.
Multi-sorting fields can lead to an error. For example, go to the "Reports" page and select the following fields in order:
Name
Format
Creator
Created At
And "ActiveRecord::StatementInvalid" error will be displayed:
ActiveRecord::StatementInvalid in Reports#index
Showing /Users/dsteelma/work/github/annual-staffing-request/app/views/reports/index.html.erb where line #26 raised:
SQLite3::SQLException: ambiguous column name: created_at: SELECT "reports"."id" AS t0_r0, "reports"."output" AS t0_r1, "reports"."parameters" AS t0_r2, "reports"."format" AS t0_r3, "reports"."status" AS t0_r4, "reports"."name" AS t0_r5, "reports"."user_id" AS t0_r6, "reports"."created_at" AS t0_r7, "reports"."updated_at" AS t0_r8, "reports"."status_message" AS t0_r9, "users"."id" AS t1_r0, "users"."cas_directory_id" AS t1_r1, "users"."name" AS t1_r2, "users"."created_at" AS t1_r3, "users"."updated_at" AS t1_r4, "users"."admin" AS t1_r5 FROM "reports" LEFT OUTER JOIN "users" ON "users"."id" = "reports"."user_id" ORDER BY reports.name desc, format desc, users.name desc, created_at desc LIMIT ? OFFSET ?
Given these issues, and time constraints, this issue is being reopened, will likely not be in the v2.1.0 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows sorting on the reports index table.
https://issues.umd.edu/browse/LIBITD-993