Skip to content

Fix packaging metadata and short-series validation#39

Draft
Copilot wants to merge 1 commit into
mainfrom
copilot/find-bugs-in-codebase
Draft

Fix packaging metadata and short-series validation#39
Copilot wants to merge 1 commit into
mainfrom
copilot/find-bugs-in-codebase

Conversation

Copilot AI commented May 27, 2026

Copy link
Copy Markdown

This change removes packaging/install failures and hardens the ADF helpers against undersized inputs. It also aligns dependency metadata with valid spec syntax so the project can be installed reliably.

  • Packaging metadata

    • Use README.md as the long description source.
    • Declare markdown content type explicitly.
    • Remove the stale README.rst manifest entry.
    • Normalize dependency version constraints to valid specifiers.
  • Input validation

    • Reject series with 30 or fewer observations in both fracadf1 and fracadf2.
    • Fail fast with a clear ValueError instead of passing invalid truncation values downstream.

Example:

fracadf1(X)  # raises ValueError if len(X) <= 30
fracadf2(X)  # raises ValueError if len(X) <= 30

Comment thread requirements.txt
statsmodels>=0.11.*
numpy>=1.18,<2
scipy>=1.4,<2
statsmodels>=0.11

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set to statsmodels>=0.11,<1

Comment thread setup.py
'statsmodels>=0.11.*',
'numpy>=1.18,<2',
'scipy>=1.4,<2',
'statsmodels>=0.11',

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set to statsmodels>=0.11,<1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants