Skip to content

hyrax 2.0 Beta4#149

Open
VivianChu wants to merge 1 commit into
developfrom
feature/evaluate_hyrax4
Open

hyrax 2.0 Beta4#149
VivianChu wants to merge 1 commit into
developfrom
feature/evaluate_hyrax4

Conversation

@VivianChu

Copy link
Copy Markdown
Member

Fixes #145 ; refs #145

Evaluate Hyrax 2.0 beta4 (clean) vs Horton as-is.

@ucsdlib/developers - please review

Comment thread spec/spec_helper.rb Outdated
config.example_status_persistence_file_path = 'spec/examples.txt'

# config.profile_examples = 10
=begin

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/BlockComments: Do not use block comments.

Comment thread spec/spec_helper.rb Outdated
config.shared_context_metadata_behavior = :apply_to_host_groups

# The settings below are suggested to provide a good initial experience
# with RSpec, but feel free to customize to your heart's content.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 2).

Comment thread spec/spec_helper.rb Outdated
# a real object. This is generally recommended, and will default to
# `true` in RSpec 4.
mocks.verify_partial_doubles = false
#mocks.syntax = :expect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/LeadingCommentSpace: Missing space after #.

Comment thread spec/rails_helper.rb Outdated
unless example.metadata[:type] == :view || example.metadata[:no_clean]
ActiveFedora::Cleaner.clean!
end
end

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

Comment thread spec/rails_helper.rb Outdated
# arbitrary gems may also be filtered via:
# config.filter_gems_from_backtrace("gem name")

config.before :each do |example|

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSpec/HookArgument: Omit the default :each argument for RSpec hooks.

Comment thread spec/rails_helper.rb Outdated
config.filter_rails_from_backtrace!
# arbitrary gems may also be filtered via:
# config.filter_gems_from_backtrace("gem name")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

Comment thread app/models/solr_document.rb Outdated
use_extension(Hydra::ContentNegotiation)

use_extension( Hydra::ContentNegotiation )

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

Comment thread app/models/solr_document.rb Outdated

use_extension(Hydra::ContentNegotiation)

use_extension( Hydra::ContentNegotiation )

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/SpaceInsideParens: Space inside parentheses detected.

@VivianChu VivianChu force-pushed the feature/evaluate_hyrax4 branch from 2fd55c5 to 9c64435 Compare November 28, 2017 23:55
Update ruby version

Fix rubocop defenses

Fix rubocop defenses
@VivianChu VivianChu force-pushed the feature/evaluate_hyrax4 branch from 9c64435 to ae09f5c Compare November 29, 2017 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants