Fix a cache issue with edit_user not cleaning up old expire and status marks#581
Open
jonasbardino wants to merge 1 commit into
Open
Fix a cache issue with edit_user not cleaning up old expire and status marks#581jonasbardino wants to merge 1 commit into
jonasbardino wants to merge 1 commit into
Conversation
… marks for the original user are not removed after edit_user completes. This should be mostly harmless but can interfere with multiple renames where the temporary 'locked' mark doesn't get removed and can then get in the way. Add clean up as a part of edit_user to address the issue. Includes a regression test which helped confirm the issue and now assures it is fixed.
jonasbardino
changed the title
jonasbardino
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing clean up of expire and status cache marks for the original user during
edit_user. This should be mostly harmless but in combination with the introduction of temporary account locking (#406) can interfere e.g. with multiple renames where the temporary'locked'mark doesn't get removed and can then later get in the way. Add clean up as a part ofedit_userto address the issue.Includes a regression test which helped confirm the issue and now assures it is fixed.