Implement fundamental unit test coverage of the accountstate module.#580
Merged
Merged
Conversation
Fixes a corner-case bug in `reset_account_expire_cache` when called with a specific `client_id` rather than the default (None) to reset all expire marks.
jonasbardino
added
bug
…stants to other existing tests for consistency.
Martin-Rehr
reviewed
Jun 19, 2026
Martin-Rehr
reviewed
Jun 19, 2026
Martin-Rehr
left a comment
Martin-Rehr
left a comment
Contributor
There was a problem hiding this comment.
Approved when comment addressed
independently even if the assertRaises does not kick in. The tested code is a bit clunky to quietly patch incorrect use but this version should make the test more consistent. Fixed a couple of similar issues with othe tests using a `with X` construct and not keeping variables aligned. Simplified a few `self.configuration` uses where we already have aliased it as `configuration`.
Contributor
Author
|
Thanks for the review and feedback. I've tried to address it, and deleted the extra comment you had marked as obsolete but noted you couldn't delete. |
…alid values to avoid inconsistent handling. The underlying function could really use more robust handling of such invalid values but for now we just want to make sure that the tests cover the current behaviour in order to let the UUID version aim for bug-for-bug compatibility as a start.
Contributor
Thanks, looks good |
… test using email alias.
jonasbardino
added a commit
that referenced
this pull request
Jun 23, 2026
…D user ID format cases. Also tests the recently adjusted check_account_accessible helper thoroughly.
jonasbardino
added a commit
that referenced
this pull request
Jun 23, 2026
…D user ID format cases. Also tests the recently adjusted check_account_accessible helper thoroughly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement fundamental unit test coverage of the
accountstatemodule.Fixes a corner-case bug in
reset_account_expire_cachewhen called with a specificclient_idrather than the default (None) to reset all expire marks. The specificclient_idversion is not yet used in any actual code, so it should be safe.Originally developed for the UUID user format support work in #561 but this part makes for a stand-alone PR to first increase overall unit test coverage.