Only install workflows dependencies if enabled#162
Open
jonasbardino wants to merge 1 commit into
Open
Conversation
…RKFLOWS` to avoid including it on sites where workflows aren't enabled. With `nbconvert` depending on the `bleach` library, which is abandoned and now has a couple of security issues we can't patch on python 3.9, it becomes problematic to have in deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the installation of
nbconvertand friends depend onENABLE_WORKFLOWSto avoid including it on sites where workflows aren't enabled. Withnbconvertdepending on thebleachlibrary, which is abandoned and now has a couple of security issues we can't patch on python 3.9, it becomes problematic to have in deployment.