CTP-6662: Fix submission button not visible when personal deadline exists. - #310
Open
cwarwicker wants to merge 1 commit into
Open
CTP-6662: Fix submission button not visible when personal deadline exists.#310cwarwicker wants to merge 1 commit into
cwarwicker wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a permission/visibility issue in mod_coursework where students with an active personal deadline could not see the “Upload your submission” action after the main coursework deadline had passed.
Changes:
- Adds an ability rule to allow new submissions when a student has a personal deadline in the future.
- Adds a Behat scenario to cover submitting after the default deadline when a personal deadline exists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
classes/ability.php |
Adds a new permission rule to allow “new submission” when a valid personal deadline exists. |
tests/behat/deadline.feature |
Adds a UI scenario asserting the submission action is visible when a personal deadline is present. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.