Conversation
Collaborator
Wow, that's impressive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets issue #120.
The test run (on Discord) with 128 MPI ranks fails because all ranks simultaneously load large (~1.2 GB) HDF5 opacity files into private RAM. With 5 molecules and 128 ranks, that's about 768 GB allocated on one node.
Every rank called
self._spec_dict["xsecarr"][()]which reads the entire dataset into private RAM before moving it to shared memory. Fix: only the shared-memory root rank (rank 0 per node) loads the data from disk. Non-root ranks passNonetoallocate_as_shared()and attach to shared memory without ever holding a private copy.Also this line
mem = GlobalCache()["xsec_in_memory"] or Trueis problematic because it always returns True, so it was impossible to ever disable in-memory loading.I have also added some explicit
close()for the HDF5 files.With these modifications, the test does not fail anymore of oom issues, so I invite you to test this fix.
(Summary) Memory impact: