Add coordinate distance function#319
Merged
Merged
Conversation
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
joelridden
previously approved these changes
Jul 2, 2024
sungeunbae
previously approved these changes
Jul 2, 2024
claudio525
previously approved these changes
Jul 2, 2024
lispandfound
dismissed stale reviews from claudio525, sungeunbae, and joelridden
via
30c014d
joelridden
approved these changes
Jul 2, 2024
AndrewRidden-Harper
approved these changes
Jul 3, 2024
claudio525
approved these changes
Jul 4, 2024
sungeunbae
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not included in geo only really because it only works for coordinates in bounds for NZTM. Open to moving this to geo. Loosely required for ucgmsim/source_modelling#1 but I figured that a more accurate distance measurement with the potential for vectorisation was worth inclusion in geo.