Change default to load embedded DTB on matching compatible#18
Merged
Conversation
tobhe
force-pushed
the
dtb_override
branch
2 times, most recently
from
55844c7 to
c910529
Compare
kukrimate
approved these changes
Aug 21, 2025
kukrimate
left a comment
kukrimate
left a comment
Collaborator
There was a problem hiding this comment.
I think this is fine.
xypron
reviewed
Aug 21, 2025
xypron
reviewed
Aug 21, 2025
Contributor
|
Please, describe all command line attributes in the README. |
Collaborator
Author
|
cc @TravMurav, related to yesterday's IRC discussion |
Add stubble.dtb_override option to disable this new behaviour. Signed-off-by: Tobias Heider <tobias.heider@canonical.com>
Signed-off-by: Tobias Heider <tobias.heider@canonical.com>
tobhe
changed the title
Signed-off-by: Tobias Heider <tobias.heider@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide
stubble.dtb_overridecommand line option to change the default and prefer the original dtb.Multiple people have noted that this might be a saner default behavior.
My main concern is that it could break custom setups where users have modified their local dtbs to get a machine running properly but they can easily pass the command line option to make it work again.