Skip to content

Allow to build runtime from custom sdk#364

Open
sergio-costas wants to merge 3 commits into
ubuntu:gnome-42-2204from
sergio-costas:allow-to-build-runtime-from-custom-sdk
Open

Allow to build runtime from custom sdk#364
sergio-costas wants to merge 3 commits into
ubuntu:gnome-42-2204from
sergio-costas:allow-to-build-runtime-from-custom-sdk

Conversation

@sergio-costas

@sergio-costas sergio-costas commented May 27, 2026

Copy link
Copy Markdown
Contributor

This patch adapts the script from gnome-46-2404 that allows to build the Runtime from a custom, prebuilt SDK. It is needed to be able to test any PR in the SDK using CI.

It also fixes the CRAFT_ARCH_TRIPLET warnings.

@sergio-costas sergio-costas requested review from 3v1n0 and nteodosio May 27, 2026 11:53
@sergio-costas sergio-costas force-pushed the allow-to-build-runtime-from-custom-sdk branch from 67edd7e to dfcc633 Compare May 27, 2026 13:43
This patch adapts the script from gnome-46-2404 that allows to
build the Runtime from a custom, prebuilt SDK. It is needed to
be able to test any PR in the SDK using CI.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for building the gnome-42-2204 runtime snap against a custom, prebuilt SDK snap (e.g., for CI validation of SDK PRs), instead of always pulling the SDK from the Snap Store.

Changes:

  • Extend snap/snapcraft.yaml to optionally consume a locally provided SDK snap during the gnome-sdk part build.
  • Add local-build.py to generate a temporary modified snapcraft configuration and run a local build (or prepare-only mode for CI).
  • Expand README.md with usage documentation for building with a local SDK snap.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
snap/snapcraft.yaml Adds conditional logic to use a local SDK snap and adjusts architecture-triplet path usage.
README.md Documents the new local SDK build workflow and the local-build.py script.
local-build.py New helper script to generate a modified snapcraft config and drive local/CI builds using a local SDK snap.
Comments suppressed due to low confidence (1)

snap/snapcraft.yaml:56

  • When LOCAL_SDK_SNAP is set, this branch doesn’t set sdk_version in the script itself, but it’s used later in version="${project_version}-sdk${sdk_version}". With set -u, the build depends on sdk_version being provided via the part’s environment (e.g., by local-build.py). Consider deriving it from the local snap here (or explicitly validating it) to make the snapcraft build logic self-contained and less fragile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread README.md
Comment thread local-build.py
Comment thread local-build.py
Comment thread local-build.py Outdated
Comment thread local-build.py
sergio-costas and others added 2 commits May 27, 2026 17:53
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sergio-costas sergio-costas requested a review from aleasto June 3, 2026 11:01
Comment thread local-build.py
Comment thread snap/snapcraft.yaml
@sergio-costas sergio-costas requested a review from 3v1n0 June 12, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants