Allow to build runtime from custom sdk#364
Open
sergio-costas wants to merge 3 commits into
Open
Conversation
67edd7e to
dfcc633
Compare
This patch adapts the script from gnome-46-2404 that allows to build the Runtime from a custom, prebuilt SDK. It is needed to be able to test any PR in the SDK using CI.
dfcc633 to
7a77603
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for building the gnome-42-2204 runtime snap against a custom, prebuilt SDK snap (e.g., for CI validation of SDK PRs), instead of always pulling the SDK from the Snap Store.
Changes:
- Extend
snap/snapcraft.yamlto optionally consume a locally provided SDK snap during thegnome-sdkpart build. - Add
local-build.pyto generate a temporary modified snapcraft configuration and run a local build (or prepare-only mode for CI). - Expand
README.mdwith usage documentation for building with a local SDK snap.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| snap/snapcraft.yaml | Adds conditional logic to use a local SDK snap and adjusts architecture-triplet path usage. |
| README.md | Documents the new local SDK build workflow and the local-build.py script. |
| local-build.py | New helper script to generate a modified snapcraft config and drive local/CI builds using a local SDK snap. |
Comments suppressed due to low confidence (1)
snap/snapcraft.yaml:56
- When
LOCAL_SDK_SNAPis set, this branch doesn’t setsdk_versionin the script itself, but it’s used later inversion="${project_version}-sdk${sdk_version}". Withset -u, the build depends onsdk_versionbeing provided via the part’s environment (e.g., bylocal-build.py). Consider deriving it from the local snap here (or explicitly validating it) to make the snapcraft build logic self-contained and less fragile.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
3v1n0
reviewed
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adapts the script from gnome-46-2404 that allows to build the Runtime from a custom, prebuilt SDK. It is needed to be able to test any PR in the SDK using CI.
It also fixes the CRAFT_ARCH_TRIPLET warnings.