Skip to content

paramter issuer in pam config splitted into mutiple tokens #28

Open
pelzlbauer wants to merge 34 commits into
uber:masterfrom
bolkedebruin:master
Open

paramter issuer in pam config splitted into mutiple tokens #28
pelzlbauer wants to merge 34 commits into
uber:masterfrom
bolkedebruin:master

Conversation

@pelzlbauer

@pelzlbauer pelzlbauer commented Aug 16, 2022

Copy link
Copy Markdown

Modified pam_jwt.go to allow x509 compatible issuer, fixed by using strings.SplitN instead of strings.Split:

func pamAuthenticate(username string, authToken string, argv []string) (string,
        var verifyUser bool = true
 
        for _, arg := range argv {
-               opt := strings.Split(arg, "=")
+               opt := strings.SplitN(arg, "=", 2)
                switch opt[0] {
                case "secret":
                        secret = opt[1]

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pmoody-

pmoody- commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

what is pam_jwt? why are you distributing a binary file? this looks like a completely different module. you've totally removed the ssh cert auth.

@pmoody- pmoody- left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to create a new module? you've removed all of the ssh auth stuff. and you're distributing a binary file .. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants