paramter issuer in pam config splitted into mutiple tokens #28
Open
pelzlbauer wants to merge 34 commits into
Open
paramter issuer in pam config splitted into mutiple tokens #28pelzlbauer wants to merge 34 commits into
pelzlbauer wants to merge 34 commits into
Conversation
|
|
Contributor
|
what is pam_jwt? why are you distributing a binary file? this looks like a completely different module. you've totally removed the ssh cert auth. |
pmoody-
suggested changes
Aug 16, 2022
pmoody-
left a comment
Contributor
There was a problem hiding this comment.
did you mean to create a new module? you've removed all of the ssh auth stuff. and you're distributing a binary file .. ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified pam_jwt.go to allow x509 compatible issuer, fixed by using strings.SplitN instead of strings.Split: