Skip to content

Conditionally skip username check within certificate principals #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArmaanT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conditionally skip username check within certificate principals #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pam_ussh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,16 @@ func authenticate(w io.Writer, uid int, username, ca string, principals map[stri
continue
}

if err := c.CheckCert(username, cert); err != nil {
// If a manual set of principals is provided, don't require
// the username to be in the certificate's principals
// Principals are verified at the end of this function
testedPrincipal := username
if len(principals) > 0 && len(cert.ValidPrincipals) > 0 {
testedPrincipal = cert.ValidPrincipals[0]
}

if err := c.CheckCert(testedPrincipal, cert); err != nil {
pamLog("Error validating cert: %v\n", err)
continue
}

Expand Down