Cope with proposed change in gdal.Open (gdal/pull/14763)#192
Open
neilflood wants to merge 2 commits into
Open
Conversation
Member
Author
|
I will leave this PR tentative, until:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming GDAL pull request OSGeo/gdal#14763 will cause a change in behaviour of
gdal.Open. We rely on the old behaviour inrios.applier.readAllImgInfo, where we expect that therios.fileinfo.ImageInfoclass will raise an exception if called on a vector file. Under the new behaviour, this would no longer be true.This PR changes the ImageInfo constructor to explicitly use
gdal.OpenExwith suitable flags to reproduce the expected behaviour. This appears to work fine under current versions of GDAL.I think this is the only place that should be affected by the change, most uses of
gdal.Openshould be fine.