Add rw_chain#51
Open
T0mstone wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I basically implemented #46 (comment) as well as I could.
The use of
Vecmakes this require theallocfeature; I could also imagine a similar API with a limit, using an array instead (it wouldn't even need to depend onarrayvecsince the unusedusizes could just be0, which isn't a valid address anyway), but I'll leave that for the future (if anyone turns out to need it).This is somewhat barebones with regards to polish - I've only written tests for
TCell. Should I duplicate these for all the other flavors?Also, I haven't written any documentation yet. Let me know if you want to accept this, then I'll try to write some.