fix(deps): update dependency org.jasig.portal:uportal-soffit-renderer to v5.17.8#77
Open
renovate[bot] wants to merge 1 commit into
Open
fix(deps): update dependency org.jasig.portal:uportal-soffit-renderer to v5.17.8#77renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
6ce3aa5 to
9d80e7c
Compare
9d80e7c to
c5cd157
Compare
c5cd157 to
033971f
Compare
033971f to
7fb371a
Compare
7fb371a to
799327b
Compare
799327b to
8f24179
Compare
ChristianMurphy
approved these changes
Nov 11, 2023
8f24179 to
697a046
Compare
697a046 to
9b36600
Compare
9b36600 to
c30ce6f
Compare
9d8f875 to
00f9294
Compare
00f9294 to
305f148
Compare
305f148 to
e37e28c
Compare
e37e28c to
e4d1599
Compare
e4d1599 to
41f07d7
Compare
41f07d7 to
92b4529
Compare
92b4529 to
58e53b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.2.0→5.17.8Release Notes
uPortal-Project/uPortal (org.jasig.portal:uPortal-soffit-renderer)
v5.17.8: uPortal v5.17.8Patch release on top of v5.17.7, completing uPortal core's side of the resource-server consolidation. Swaps every internal
/ResourceServingWebapp/reference in skin descriptors, admin JSPs, and chrome assets onto/resource-server/, and trims a set of 2008–2015 utility-lib webjar dependencies that are either CVE-prone or native-replaceable on modern browsers.Refactor
Consolidate skin + JSP onto
/resource-server/(#2983)Moves uPortal core's skin descriptors, admin JSPs, and chrome-asset references off the legacy
/ResourceServingWebapp/context onto/resource-server/. Drops a bundle of 2008–2015 utility libraries (lodash 4.17.4, modernizr 2.6.2, normalize.css 2.1.2, four polyfill webjars) that were either CVE-prone, native-replaceable on modern browsers, or both. Also removes dead<rs:compressJs>taglib wrappers (already a no-op upstream now that minification has moved to esbuild).Two commits land together: the main consolidation (~30 files: JSP cleanup, SCSS path swaps, tango/famfamfam icon URL swaps, dead webjar deps removed) and a finishing touch in
respondr/common/common_skin.xmlfor the threeresource="true"entries (underscore, backbone, jquery-plugins/rating) that the first pass missed. All three libs are served at byte-identical relative paths under the modern overlay.Docs
Prefer
keys.openpgp.orgoverkeyserver.ubuntu.com(#2984)Brings the release-guide keyserver instructions in line with the Maven ecosystem release guide. The Central Publisher Portal queries
keys.openpgp.orgfirst when validating signatures; a key only onkeyserver.ubuntu.comwill fail signature validation non-deterministically. Includes the email-confirmation caveat for identity packets and a per-session verification curl.Manual NOTICE/license review step pre-Testing (#2985)
Adds a "Review NOTICE and License Headers" section to the release guide between "Review Dependencies" and "Testing". Cross-links to the Maven release guide's automated equivalent (which Gradle uPortal lacks today) and provides a quick
grepheuristic for missing Apache license headers on changed files.Upgrade notes
/ResourceServingWebapp/is no longer requested by uPortal core, but the path itself is still served by the overlay untilresource-server1.5.4 ships anduPortal-startretiresResourceServingWebapp. Browsers will see network requests cleanly addressed to/resource-server/.resource-server1.5.4 release where the legacy JS bundles ship.pom.xml/gradle.properties. The defaults no longer pull them in.v5.17.7: uPortal v5.17.7Single-fix patch on top of v5.17.5. Supersedes v5.17.6, which was a botched version-bump-only release (no functional changes from v5.17.5); deployers should skip 5.17.6 and consume 5.17.7 instead.
Fixes
Deprecate the LESS pipeline in the
respondrskin (#2982)uPortal-webapp/src/main/webapp/media/skins/respondr/common/common.lessstill pulled in five sub-files —variables.less,mixins.less,regions.less,gallery.less,tags.less— that were removed during the Bootstrap 5 / SCSS migration. Any consumer runningcompileLessagainst this skin failed with "file not found" on the first dropped import, blocking uPortal-start's quickstart build (the symptom that surfaced this wascompileLess0failing onuPortal-startPR #694).This change comments out the five orphaned
@importlines, swaps the Bootstrap LESS import for the compiledbootstrap.css(so the file still produces usable CSS), and tags each entry with aDEPRECATEDbanner pointing at the SCSS pipeline as the supported path forward. The file itself is kept rather than deleted so any skin overlay still referencing it continues to compile during the deprecation window.Upgrade notes
No configuration or deployment changes required. Drop-in replacement for v5.17.5. The
respondrLESS pipeline remains compiled but is now formally deprecated — new skin work should target the SCSS pipeline.v5.17.5: uPortal v5.17.5Single-fix patch on top of v5.17.4.
Fixes
Drop duplicate Bootstrap 5 includes from the respondr skin (#2980)
respondr/common/common_skin.xmldeclared the Bootstrap 5 CSS bundle and the JS bundle three times each: a<… included=\"plain\">variant, a<… included=\"aggregated\">variant, and a third unqualified entry that matched both render modes. The unqualified entry causedbootstrap.bundle.min.jsto load twice in the browser, attaching two delegated click handlers per dropdown toggle. A single user click on a portlet's Options menu toggled the menu open then immediately back to closed, so every UX flow gated on opening that menu — favorites add/remove, rate-this-portlet, edit-mode entry, return-to-dashboard from a maximized portlet — appeared silently broken across the welcome page and every other dashboard.The fix is the deletion of the two unqualified entries; the
included=\"plain\"/included=\"aggregated\"pair already covers every render mode.The duplication originally landed during the Bootstrap 5 migration when two contributors added the same asset from different mental models — unconditional include and mode-qualified include. Both were applied; neither was removed.
Upgrade notes
No configuration or deployment changes required. Drop-in replacement for v5.17.4.
v5.17.4: uPortal 5.17.4Patch release on top of v5.17.3.
Fix
The obsolete
ch.qos.logback.classic.selector.servlet.ContextDetachingSCLlistener has been removed fromuPortal-webapp/src/main/webapp/WEB-INF/web.xml(PR #2976). The class was part of Logback's J2EE selector machinery and was removed in Logback 1.3.x.Unlike NotificationPortlet (which still bundles Logback 1.1.11), uPortal core itself bundles Logback 1.5.32 today — so this listener was an active bug, not a latent one. It was a known tripwire across the fleet during the 2026-05 wave: every portlet that bumped Logback to 1.3+ via
uportal-portlet-parentv51 hitClassNotFoundExceptionat context startup with this exact listener. The same fix landed across the fleet (Announcements 2.5.3, Calendar 2.7.2, JasigWidget 2.4.2, NewsReader 5.1.4, SimpleContent 3.4.2, Notification 4.8.3).The listener also has no functional value here — Logback's modern auto-cleanup handles classloader GC and JMX deregistration without needing this hook.
Dependency bumps
Routine Renovate-driven patch bumps in established libraries:
commons-cli→ 1.11.0 (#2967)commons-codec→ 1.22.0 (#2968)commons-io→ 2.22.0 (#2971)commons-pool2→ 2.13.1 (#2974)tika-core→ 3.3.0 (#2975)jsoup→ 1.22.2 (#2978)easymock→ 5.6.0 (#2977)Docs
RELEASE.md(#2970).CHANGESandHISTORY.md(#2969).Compatibility
v5.17.3uPortal 5.17.3
This is a maintenance release of uPortal. The headline change is a substantial frontend modernization that's been in flight for a long time finally landing — Bootstrap 3 → 5, jQuery 4, LESS → SCSS, and removal of Fluid Infusion across the
respondrskin. The release also folds in security updates (commons-lang3, commons-beanutils, guava, hsqldb), refactor work on the LimitingTee output stream, and the routine Renovate dependency-hygiene cycle.Thanks to @Naenyn (Bill Smith) for owning the frontend modernization end-to-end, and to all the contributors who made this release possible — including the Renovate and Dependabot bots whose dep-hygiene PRs accumulated to a meaningful chunk of the changeset.
Changes Affecting Deployments
respondrskin. Customized skins will need updating. Review your overrides underuPortal-webapp/src/main/webapp/media/skins/for:.lessfiles (now.scss)Features / Refactors
LimitingTeecallbacks fromFunction<T,?>toConsumer<T>(#2945) and silence the corresponding ErrorProne CheckReturnValue (#2943).Fixes
resource-server-utilstransitive deps to avoid version pinning conflicts (#2944).LimitingTeeOutputStreamTest(latent bug surfaced by the commons-io 2.22 bounds tightening, folded into #2964).uPortal-webappbuildscript classpath to avoid a commons-lang3 split between Gradle's bundled version and the version transitively pulled in via resource-server (folded into #2964).Documentation
AGENTS.mdwith the project's actual Java 11 baseline, replacing inaccurate "ban Java 9+" wording (#2947).Security Updates
org.hsqldb:hsqldb→ 2.7.1 (#2671) and 2.7.4 (#2949)commons-beanutils:commons-beanutils→ 1.11.0 (#2934)org.apache.commons:commons-lang3→ 3.18.0 (#2936) and 3.20.0 (#2951)com.google.guava:guava→ v32 (#2939)Other Dependency Updates
org.jasig.resourceserver:resource-server→ 1.5.3 (#2964)aws-java-sdk-s3,joda-time,ant,lombok,spotbugs,groovy,jackson,logback-classic,codenarc,prettier,errorproneplugin,immutable. PRs: #2946, #2952, #2953, #2954, #2955, #2956, #2957, #2958, #2959, #2960, #2962, #2963.Full Changelog: uPortal-Project/uPortal@v5.17.2...v5.17.3
v5.17.2What's Changed
Fixes
Dependency Updates
Chores
Documentation
Tests
Release Infrastructure
Full Changelog: uPortal-Project/uPortal@v5.17.1...v5.17.2
v5.17.1What's Changed
Chores
Dependency Updates
Documentation
New Contributors
Full Changelog: uPortal-Project/uPortal@v5.17.0...v5.17.1
v5.17.0What's Changed
New Contributors
Full Changelog: uPortal-Project/uPortal@v5.16.1...v5.17.0
v5.16.1What's Changed
Full Changelog: uPortal-Project/uPortal@v5.16.0...v5.16.1
v5.16.0What's Changed