fix(ember-tsc): respect local imports over template globals#1114
Open
aklkv wants to merge 1 commit into
Open
Conversation
When the user has imported a binding with the same name as one of the
template's configured globals (e.g. `import { on } from '@ember/modifier'`
where `on` is also listed in the Ember 7.1+ built-in keywords introduced
in 1.6.1), prefer the local import.
Without this filter the template transform routes the path through
`__glintDSL__.Globals[<name>]` and silently shadows the user's import.
That is a regression for projects on `ember-source < 7.1` where the
corresponding `Globals` entry is gated by `Ember71Only<T>` and resolves
to `never` -- producing TS2349 'This expression is not callable. Type
"never" has no call signatures.' on otherwise valid code such as
import { on } from '@ember/modifier';
<template>
<select {{on "change" this.update}} />
</template>
Fixes typed-ember#1113.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user has imported a binding with the same name as one of the template's configured globals (e.g.
import { on } from '@ember/modifier'whereonis also listed in the Ember 7.1+ built-in keywords introduced in 1.6.1), prefer the local import.Without this filter the template transform routes the path through
__glintDSL__.Globals[<name>]and silently shadows the user's import. That is a regression for projects onember-source < 7.1where the correspondingGlobalsentry is gated byEmber71Only<T>and resolves tonever-- producing TS2349 'This expression is not callable. Type "never" has no call signatures.' on otherwise valid code such asFixes #1113.