Skip to content

Refactor to React-only library#8

Merged
ty2k merged 3 commits into
mainfrom
feature/react-refactor
Jun 1, 2026
Merged

Refactor to React-only library#8
ty2k merged 3 commits into
mainfrom
feature/react-refactor

Conversation

@ty2k

@ty2k ty2k commented Jun 1, 2026

Copy link
Copy Markdown
Owner

This refactors the library to be React-only so the package.json makes sense and peerDependencies are applied appropriately.

@ty2k ty2k requested a review from Copilot June 1, 2026 16:06
@ty2k ty2k self-assigned this Jun 1, 2026
@ty2k ty2k added the enhancement New feature or request label Jun 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Consolidates the previously nested src/react React subpackage into the repository root, eliminating the two-package build flow in favor of a single package layout.

Changes:

  • Flattens the src/react/* configuration, scripts, and dependencies up into root-level package.json, tsconfig.json, .gitignore, etc., and removes the corresponding nested files.
  • Updates CI workflows to drop the nested working-directory and path filters.
  • Removes the previously-checked-in dist/ build artifacts and the __tests__/importTests.test.ts import-smoke test, and simplifies README.md headings (no longer multi-framework).

Reviewed changes

Copilot reviewed 12 out of 44 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
package.json Renames package to vkb-react, replaces publish metadata/scripts with the React subpackage scripts and devDeps.
tsconfig.json Converted to a solution-style file referencing app/node/types tsconfigs.
src/react/tsconfig.app.json Adds tooling config files to include.
src/react/{package.json,tsconfig.json,README.md,.nvmrc,.gitignore} Removed as part of the flatten.
.gitignore Pulls in the React subpackage ignores at the root.
README.md Removes multi-framework framing; collapses heading levels.
.github/workflows/{publish,test-react}.yaml Drops the src/react working-directory and path-filters.
vitest.config.ts, tests/importTests.test.ts, dist/** Removed prior dist-import smoke test and committed build output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json
Comment thread package.json
Comment thread README.md
Comment thread .github/workflows/publish.yaml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 44 changed files in this pull request and generated 1 comment.

Comment thread package.json
@ty2k ty2k merged commit e1bafb4 into main Jun 1, 2026
1 check passed
@ty2k ty2k deleted the feature/react-refactor branch June 1, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants