Refactor to React-only library#8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Consolidates the previously nested src/react React subpackage into the repository root, eliminating the two-package build flow in favor of a single package layout.
Changes:
- Flattens the
src/react/*configuration, scripts, and dependencies up into root-levelpackage.json,tsconfig.json,.gitignore, etc., and removes the corresponding nested files. - Updates CI workflows to drop the nested
working-directoryand path filters. - Removes the previously-checked-in
dist/build artifacts and the__tests__/importTests.test.tsimport-smoke test, and simplifiesREADME.mdheadings (no longer multi-framework).
Reviewed changes
Copilot reviewed 12 out of 44 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Renames package to vkb-react, replaces publish metadata/scripts with the React subpackage scripts and devDeps. |
| tsconfig.json | Converted to a solution-style file referencing app/node/types tsconfigs. |
| src/react/tsconfig.app.json | Adds tooling config files to include. |
| src/react/{package.json,tsconfig.json,README.md,.nvmrc,.gitignore} | Removed as part of the flatten. |
| .gitignore | Pulls in the React subpackage ignores at the root. |
| README.md | Removes multi-framework framing; collapses heading levels. |
| .github/workflows/{publish,test-react}.yaml | Drops the src/react working-directory and path-filters. |
| vitest.config.ts, tests/importTests.test.ts, dist/** | Removed prior dist-import smoke test and committed build output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the library to be React-only so the
package.jsonmakes sense andpeerDependenciesare applied appropriately.