Fix last press timekeeping#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes shift-or-caps double-press timekeeping so the second press can correctly toggle persistent caps lock mode (matching the intended mobile-keyboard behavior and unblocking the failing test run referenced in the PR description).
Changes:
- Record the timestamp of the most recent
shift-or-capspress (instead of clearing it), enabling double-press detection for caps lock toggling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the broken logic in how last presses are tracked in the
handleShiftOrCapsPress(), fixing the failing test from this test suite run.Without this change,
shiftkeys work as expected, butshift-or-capsandcapsonly work as one-shot shift buttons, not to keep a persistent caps lock.