use label as a subject-identifier-type - #19
Open
MegaphoneJon wants to merge 1 commit into
Open
Conversation
twomice
reviewed
Oct 6, 2020
| } else if (typeof condition.selector != 'undefined') { | ||
| el = $(condition.selector); | ||
| } else if (typeof condition.label != 'undefined') { | ||
| condition.id = CRM.$("label:contains(" + condition.label + ")").attr('for'); |
Owner
There was a problem hiding this comment.
This seems like it could match more broadly than intended. E.g., if condition.label = 'Foo', this would match elements with label 'FooBar', 'BarFoo', etc. Any chance you could tighten this to be an exact match?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I have to unfork my version of the extension anyway, here's the only outstanding feature I have - use label as a subject identifier.
The main use case for this is to show hide the "Other Amount" when someone clicks the "Other" button. Since the "Other" element has a different ID on each page, this allows you to set the behavior once for all pages (especially future pages).