Skip to content

Issue #61: use updated crmICalText which can allow HTML - #62

Open
herbdool wants to merge 2 commits into
twomice:masterfrom
herbdool:issue-61
Open

Issue #61: use updated crmICalText which can allow HTML#62
herbdool wants to merge 2 commits into
twomice:masterfrom
herbdool:issue-61

Conversation

@herbdool

Copy link
Copy Markdown

Fixes #61

@twomice

twomice commented Jun 18, 2025

Copy link
Copy Markdown
Owner

Thanks for the PR, @herbdool . Can you explain the '29' position attribute on that modifier? It appears merely to limit the length of the first line to something less than the default 50 chars.

With '29':

X-ALT-DESC;FMTTYPE=text/html:
 <!DOCTYPE HTML PUBLIC

Without '29':

X-ALT-DESC;FMTTYPE=text/html:
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"><

Both seem perfectly valid to me, but am I missing something there?

twomice added a commit that referenced this pull request Jun 18, 2025
@MegaphoneJon

Copy link
Copy Markdown
Contributor

I did my own version of this last week. In addition to the change Herb identifies:

  • activityical_civicrm_config should have the non-boilerplate code removed. It references Smarty->plugin_dir which isn't a thing in Smarty 5.
  • The Smarty directory and its contents can be removed.

@herbdool if you don't want to handle this I'll submit an alternate PR.

@twomice

twomice commented Sep 18, 2025

Copy link
Copy Markdown
Owner

Thanks @MegaphoneJon and @herbdool . Still looking for an answer about the '29' position attribute, just to be clear myself about why it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unknown modifier 'activityicalHtml' when using CiviCRM 6.2, Smarty v5

3 participants