[pre-commit.ci] pre-commit autoupdate#732
Conversation
updates: - [github.com/psf/black-pre-commit-mirror: 25.12.0 → 26.1.0](psf/black-pre-commit-mirror@25.12.0...26.1.0)
for more information, see https://pre-commit.ci
|
ugh so this is kinda bad. Black seems to have decided that the correct number of empty lines after imports is 1 is wrong and clashes with our isort config. Unless they reconsider, I recommend switching to Ruff which I'm sure will have an option for this. |
67506ca to
c7702be
Compare
|
So small update: I was gonna admit defeat as the only person caring about this style but unfortunately, switching isort to one line after imports triggers flake8's E302. So it looks like there's no way to have empty lines enforcement and black at the same time? I'm really, really, really sad about all this and reaching out through my backchannels did nothing so unless anyone has a better idea, I'll open a PR switching to Ruff. |
6aa5dcd to
baff743
Compare
|
based on @itamarst's suggestion on Mastodon I've just killed the flake8 switch and this is ready for review |
baff743 to
374f54f
Compare
|
Hi. SOrry for late reply. I kind of ignore these automated PRs. I am happy to move to ruff and kill flake8 |
After further discussion on the PR, this seems the least terrible way forward.
a7ea6ea to
ea05e8c
Compare
|
thanks @adiroiban and no worries, I'm overwhelmed enough as it stands ;) I've dropped flake8, isort, black, and pyupgrade which simplified a lot of stuff and came with a little whitespace noise in some test files; I think that's fine. If there's interest, we can start experimenting with more rules later; I've added only what I've removed. |
ea05e8c to
5f160f8
Compare
74fb3c5 to
ea05e8c
Compare
|
looks like I'll have to monthly force-push because pre-commit.ci bases it's updates on trunk's config and keeps reverting to black/isort/flake8 :| |
ea05e8c to
ba3e714
Compare
90ff234 to
ea05e8c
Compare
|
someone please? 🥺🐶 |
updates: