Skip to content

[pre-commit.ci] pre-commit autoupdate#732

Merged
glyph merged 5 commits into
trunkfrom
pre-commit-ci-update-config
Jun 2, 2026
Merged

[pre-commit.ci] pre-commit autoupdate#732
glyph merged 5 commits into
trunkfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

updates:
- [github.com/psf/black-pre-commit-mirror: 25.12.0 → 26.1.0](psf/black-pre-commit-mirror@25.12.0...26.1.0)
@pre-commit-ci pre-commit-ci Bot requested a review from a team as a code owner February 2, 2026 19:58

@hynek hynek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay new black style!

@hynek hynek self-requested a review February 3, 2026 07:56
@hynek

hynek commented Feb 3, 2026

Copy link
Copy Markdown
Member

ugh so this is kinda bad. Black seems to have decided that the correct number of empty lines after imports is 1 is wrong and clashes with our isort config. Unless they reconsider, I recommend switching to Ruff which I'm sure will have an option for this.

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 67506ca to c7702be Compare March 2, 2026 20:42
@hynek

hynek commented Mar 3, 2026

Copy link
Copy Markdown
Member

So small update: I was gonna admit defeat as the only person caring about this style but unfortunately, switching isort to one line after imports triggers flake8's E302. So it looks like there's no way to have empty lines enforcement and black at the same time? I'm really, really, really sad about all this and reaching out through my backchannels did nothing so unless anyone has a better idea, I'll open a PR switching to Ruff.

@hynek hynek force-pushed the pre-commit-ci-update-config branch from 6aa5dcd to baff743 Compare March 8, 2026 12:02
@hynek

hynek commented Mar 8, 2026

Copy link
Copy Markdown
Member

based on @itamarst's suggestion on Mastodon I've just killed the flake8 switch and this is ready for review

@hynek hynek requested review from a team March 9, 2026 05:57
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from baff743 to 374f54f Compare April 6, 2026 20:38
@adiroiban

Copy link
Copy Markdown
Member

Hi. SOrry for late reply. I kind of ignore these automated PRs.

I am happy to move to ruff and kill flake8

After further discussion on the PR, this seems the least terrible way
forward.
@hynek hynek force-pushed the pre-commit-ci-update-config branch from a7ea6ea to ea05e8c Compare May 2, 2026 09:36
@hynek

hynek commented May 2, 2026

Copy link
Copy Markdown
Member

thanks @adiroiban and no worries, I'm overwhelmed enough as it stands ;)

I've dropped flake8, isort, black, and pyupgrade which simplified a lot of stuff and came with a little whitespace noise in some test files; I think that's fine.

If there's interest, we can start experimenting with more rules later; I've added only what I've removed.

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from ea05e8c to 5f160f8 Compare May 4, 2026 20:05
@hynek hynek force-pushed the pre-commit-ci-update-config branch from 74fb3c5 to ea05e8c Compare May 5, 2026 06:43
@hynek

hynek commented May 5, 2026

Copy link
Copy Markdown
Member

looks like I'll have to monthly force-push because pre-commit.ci bases it's updates on trunk's config and keeps reverting to black/isort/flake8 :|

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from ea05e8c to ba3e714 Compare June 1, 2026 20:56
@hynek hynek force-pushed the pre-commit-ci-update-config branch from 90ff234 to ea05e8c Compare June 2, 2026 06:23
@hynek

hynek commented Jun 2, 2026

Copy link
Copy Markdown
Member

someone please? 🥺🐶

@glyph glyph merged commit 03c2ac7 into trunk Jun 2, 2026
16 checks passed
@glyph glyph deleted the pre-commit-ci-update-config branch June 2, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants