Skip to content

fix(tuttid): finish workspace write pool migration#1241

Open
chovy-ai wants to merge 1 commit into
mainfrom
fix/sqlite-workbench-write-pool
Open

fix(tuttid): finish workspace write pool migration#1241
chovy-ai wants to merge 1 commit into
mainfrom
fix/sqlite-workbench-write-pool

Conversation

@chovy-ai

@chovy-ai chovy-ai commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use the SQLite writer pool for the remaining workbench migration transaction
  • update migration fixtures to write through the writer pool

Root cause

PR #1236 replaced SQLiteStore.db with separate writeDB and readDB pools, but the workbench target-identity migration and two test fixtures retained references to the removed db field. This makes current main fail Go compilation, including unrelated PRs rebased onto it.

Fix Scope Justification

  • Root cause: the first incorrect state is at the workspace SQLite storage boundary, where three remaining write operations reference a field removed by the read/write pool split.
  • Why this cannot be fixed at a lower layer: database/sql and SQLite are functioning correctly; the invalid field references are in Tutti-owned migration code. Mapping these operations to the existing writeDB is the smallest owned-layer correction and preserves the pool architecture introduced by fix(tuttid): separate SQLite read and write pools #1236.

Validation

  • go test ./services/tuttid/data/workspace/...
  • git diff --check

The full Go workspace runner was also attempted without the generated builtin app artifact and failed only because generated/tutti-onboarding/tutti-onboarding-0.1.0.zip was absent; the affected package passed.


Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Signed-off-by: Test <test@example.com>
@chovy-ai
chovy-ai force-pushed the fix/sqlite-workbench-write-pool branch from 3d99c4f to 31e0728 Compare July 16, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant