fix(forgejo): pass Valkey Redis URLs via env vars#48
Merged
Conversation
… interpolation Helm values are written as literals into app.ini, so $(VALKEY_PASSWORD) was not expanded. Use FORGEJO__cache__HOST etc. via additionalConfigFromEnvs which leverages Kubernetes env var interpolation.
Contributor
✅ Validation passedValidation output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$(VALKEY_PASSWORD)はリテラル文字列としてapp.iniに書き込まれてしまうFORGEJO__cache__HOST等をadditionalConfigFromEnvsで渡し、KubernetesのPod env展開で$(VALKEY_PASSWORD)を解決WRONGPASS invalid username-password pair or user is disabled