Drop logging hygiene NextUp item — premise was inaccurate#17
Merged
Conversation
The entry described a mixed log.Printf / logrus codebase, but a survey turned up zero stdlib log usage in production: all 84 call sites across 17 files use logrus (aliased as log). The only stdlib log is in lib/tailed_file/tailed_file_test.go for test diagnostics. Migrating logrus → log/slog is a separable, larger decision (no forcing function today, logrus is stable, ~84 call sites + a custom ginLogger middleware to port). Park it. If we want to revisit later under a concrete trigger (OpenTelemetry, dependency cleanup, Go upgrade), we can add a fresh entry then. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Survey turned up zero stdlib
log.Printfusage in production code — all ~84 call sites across 17 files already use logrus (aliased aslog). The only stdliblogis inlib/tailed_file/tailed_file_test.gofor test diagnostics. The "unify the loggers" framing didn't match reality.Migrating logrus →
log/slogis a separable, larger decision with no forcing function today (logrus 1.9.3 is stable and active; ~84 call sites + a customginLoggermiddleware to port). Parking it. If we later have a concrete trigger (OpenTelemetry, dep cleanup, a Go upgrade snag) we can add a fresh entry framed around that.Test plan
Docs-only change.
🤖 Generated with Claude Code