Fix test suite: remove goflow, fix bench fixtures, enable full CI - #18
Merged
Conversation
…ull CI - Remove goflow package (redundant with astflow, re-parsed files unnecessarily) - Fix 31 bench fixture headers: rename stale GTSS- prefixes to BATOU- and update expected rule IDs to match actual detections - Remove -skip flag from CI workflow so all 2440 tests run - Full test suite passes with zero failures Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-skipflag — all previously-skipped tests now pass, CI runs the full suiteRoot Causes
goflow: Redundant engine registered alongside astflow. Both ran on every Go file, but goflow's results were deduped away and never used by the call graph. Removing it eliminates unnecessary re-parsing.
Bench fixtures: The GTSS→Batou rename (ae8dfd8) updated 427 source files but skipped fixture file headers. The test engine's filename-inference fallback masked some failures, but 12 fixtures failed outright.
CI skip list: Added as a workaround for the above. No longer needed.
Test plan
make test— 2440/2440 tests pass, zero failuresgo build ./...— compiles clean🤖 Generated with Claude Code