Skip to content

První pokus odevzdání projektu - #227

Open
l-nagy-utb-fai wants to merge 33 commits into
turecekt:masterfrom
l-nagy-utb-fai:master
Open

První pokus odevzdání projektu#227
l-nagy-utb-fai wants to merge 33 commits into
turecekt:masterfrom
l-nagy-utb-fai:master

Conversation

@l-nagy-utb-fai

Copy link
Copy Markdown

První pokus odevzdání projektu

@turecekt turecekt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • soubor test.py přejmenovat na test_functions.py aby jej pytest naimportoval
  • soubor Návrh programu přejmenovat na README.md
  • odstranit soubor example.py
  • odstranit všechny soubory .html
  • dopsat docstringy do všech modulů a funkcí aby prošlo přes flake8
  • v sekci About na hlavní stránce repa následně upravit Website url na url vašich gh-pages s automaticky vygenerovanou dokumentací.

Comment thread main.py Outdated
Comment thread main.py Outdated
Comment thread main.py Outdated
Comment thread main.py Outdated
Comment thread main.py Outdated
Comment thread main.py Outdated
Comment thread main.py Outdated
l-nagy-utb-fai and others added 7 commits January 26, 2023 16:11
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>
Co-authored-by: Tomáš Tureček <42441627+turecekt@users.noreply.github.com>

@turecekt turecekt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stejně opravit i functions.py

@turecekt turecekt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • syntaxe opravena a pytest prochází bez chyby, teď ještě vyčistit kód aby prošel přes flake8 viz sekce Actions - build ve vašem repozitáři:
    flake8 .
    ./functions.py:1:1: D300 Use """triple double quotes"""
    ./functions.py:1:1: D400 First line should end with a period
    ./functions.py:15:1: D300 Use """triple double quotes"""
    ./functions.py:15:1: D400 First line should end with a period
    ./functions.py:35:1: D300 Use """triple double quotes"""
    ./functions.py:35:1: D400 First line should end with a period
    ./test_functions.py:1:1: D300 Use """triple double quotes"""
    ./test_functions.py:1:1: D400 First line should end with a period
    ./test_functions.py:4:1: E402 module level import not at top of file
    ./test_functions.py:9:1: D204 1 blank line required after class docstring
    ./test_functions.py:9:1: D300 Use """triple double quotes"""
    ./test_functions.py:9:1: D400 First line should end with a period
    ./test_functions.py:11:1: D300 Use """triple double quotes"""
    ./test_functions.py:11:1: D400 First line should end with a period
    ./test_functions.py:17:1: D300 Use """triple double quotes"""
    ./test_functions.py:17:1: D400 First line should end with a period
    ./test_functions.py:23:1: D300 Use """triple double quotes"""
    ./test_functions.py:23:1: D400 First line should end with a period
    ./test_functions.py:28:1: D300 Use """triple double quotes"""
    ./test_functions.py:28:1: D400 First line should end with a period
    ./test_functions.py:38:1: D204 1 blank line required after class docstring
    ./test_functions.py:38:1: D300 Use """triple double quotes"""
    ./test_functions.py:38:1: D400 First line should end with a period
    ./test_functions.py:40:1: D300 Use """triple double quotes"""
    ./test_functions.py:40:1: D400 First line should end with a period
    ./test_functions.py:46:1: D300 Use """triple double quotes"""
    ./test_functions.py:46:1: D400 First line should end with a period
    ./test_functions.py:52:1: D300 Use """triple double quotes"""
    ./test_functions.py:52:1: D400 First line should end with a period
    ./test_functions.py:58:1: D300 Use """triple double quotes"""
    ./test_functions.py:58:1: D400 First line should end with a period

@turecekt turecekt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v sekci About na hlavní stránce repa upravit Website url na url vašich gh-pages s automaticky vygenerovanou dokumentací.

@l-nagy-utb-fai

Copy link
Copy Markdown
Author

v sekci About na hlavní stránce repa upravit Website url na url vašich gh-pages s automaticky vygenerovanou dokumentací.

Je potřeba ještě něco udělat?

Comment thread main.py Outdated
@@ -0,0 +1,36 @@
"""Hlavní modul."""

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tento popisek trochu rozepsat

@turecekt turecekt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A u obou funkcí ve functions.py dopnit ještě datové typy parametrů funkce a návratových hodnot v definici funkce(type hints) a jejich popis v rozšířeném docstringu formou reST(:param: a :return:) viz zde: https://github.com/turecekt/vs_project/blob/master/example.py

@turecekt turecekt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akorád ještě napřed v Actions zrušit workflow "pages-build-deployment" a v nastavení repozitáře v settings v sekci Pages je nutné nastavit Build and Deployment Source na Github Actions a následně ještě zařadit navrhovanou změnu (měla by se tak po commitu automaticky přegenerovat a vystavit dokumentace).

Comment thread functions.py Outdated
l-nagy-utb-fai and others added 4 commits January 27, 2023 13:06

@turecekt turecekt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • odstranit z repozitáře soubor jekyll-gh-pages.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants