Skip to content

fixed small number issue - #4

Open
nobellium1997 wants to merge 1 commit into
tuomassalo:masterfrom
nobellium1997:master
Open

fixed small number issue#4
nobellium1997 wants to merge 1 commit into
tuomassalo:masterfrom
nobellium1997:master

Conversation

@nobellium1997

Copy link
Copy Markdown

I just swapped the characters for numbers and put in a space so that it was easier to read.

@nobellium1997

Copy link
Copy Markdown
Author

refs #2

@tuomassalo

Copy link
Copy Markdown
Owner

Hi! Late thanks for the PR. I need to point out that due to the hacky natute of the code and normal numbers being not completely unusual as the first cahracter of a <title>, this change aggravates the known issue "will mess up with titles already starting with the characters ¹...⁸" mentioned in README.

this is the problematic code: whenever tab numbering changes, these lines attempt to remove the old number from the title.

if (newTitle && numbers.includes(newTitle[0])) {
newTitle = newTitle.substr(1)
}

See also: 64ae512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants