Skip to content

chore(learn): Strengthen false positive exclusions with verification requirements; Add shared library verification to filesystem reviews #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(learn): Strengthen false positive exclusions with verification requirements; Add shared library verification to filesystem reviews #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .blick/skills/swifterpm-swift-review/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Review Swift changes for SwifterPM with the same standards as a maintainer revie
- Preserve SwiftPM-compatible dependency resolution semantics. Resolver changes should match SwiftPM behavior unless the difference is explicitly intentional and tested.
- Preserve SwifterPM storage behavior. Fetching, source checkout, registry fallback, artifact extraction, and materialization should keep using the Global CAS cache and avoid duplicating package contents unnecessarily.
- Treat registry, GitHub, and GitLab resolution paths as user-visible behavior. Verify fallback logic, identity normalization, version constraints, and source URL handling carefully.
- Prefer SwiftNIO filesystem primitives through `AsyncFileSystem` and `NIOFileSystem`. Flag new production use of `Foundation.FileManager`.
- Prefer the shared `fileSystem` instance from `tuist/FileSystem` for filesystem operations. Convert URLs to `AbsolutePath` via the in-module `URL.absolutePath` helper. Flag new production use of `Foundation.FileManager`, custom filesystem wrappers (e.g. `AsyncFileSystem`), or calls to SwiftNIO/`swift-tools-support-core` filesystem primitives when `tuist/FileSystem` already provides equivalent functionality.
- Check concurrency around cache writes, artifact extraction, and shared resolver state. Look for races, non-atomic writes, and partial materialization after failures.
- Check that temporary directories, copied e2e scenarios, and test fixtures are cleaned up.
- For e2e tests, scenarios should live under fixture folders and be copied into temporary folders before execution.
Expand Down