Skip to content

IMP apply patch to handle uncompressed layers https://github.com/containerd/containerd/issues/10134#issuecomment-2245885395#2

Open
korjek wants to merge 4 commits into
masterfrom
imp/issue-2291
Open

IMP apply patch to handle uncompressed layers https://github.com/containerd/containerd/issues/10134#issuecomment-2245885395#2
korjek wants to merge 4 commits into
masterfrom
imp/issue-2291

Conversation

@korjek

@korjek korjek commented Apr 9, 2026

Copy link
Copy Markdown

No description provided.

cwoerner and others added 4 commits July 31, 2024 02:18
in docker v25 image save (that is used in pkg_install) produces OCI compliant tarball
rules_python dropped support of pip_install since 0.27.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the addition of this file intentional?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed a Wiki

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same for this one

executable = True,
sha256 = "08b8963cce9234f57055bafc7cadd1624cdce3c5990048cea1df453d7d288bc6",
urls = [("https://storage.googleapis.com/rules_docker/" + RULES_DOCKER_GO_BINARY_RELEASE + "/puller-linux-amd64")],
urls = [("https://mirror.bazel.build/storage.googleapis.com/rules_docker/" + RULES_DOCKER_GO_BINARY_RELEASE + "/puller-linux-amd64")],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, what impact does it have changing this URL?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fixes the issue linked in the last commit message (actually the one that chanages URL) bazelbuild#2291

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@gabricc gabricc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants