allow match expressions to target variant document types#9
Merged
Conversation
Match expressions like `{"type":{"const":"core/article#prefab"}}` can now
target a specific variant, allowing constraints to be added that only apply
to that variant and not the base document type.
Previously `documentMatchAttribute` resolved variants before matching, so
match expressions could only ever see the base type. Now the raw document
type is tried first, and variant resolution is used as a fallback. This
means `{"type":{"const":"core/article"}}` still matches variant documents,
while `{"type":{"const":"core/article#prefab"}}` matches only that specific
variant.
The test adds a "prefab-setting" meta block that is declared only for
`core/article#prefab` and verifies that it is accepted on the variant but
rejected as undeclared on the base `core/article`.
danijelvukoje
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match expressions like
{"type":{"const":"core/article#prefab"}}can now target a specific variant, allowing constraints to be added that only apply to that variant and not the base document type.Previously
documentMatchAttributeresolved variants before matching, so match expressions could only ever see the base type. Now the raw document type is tried first, and variant resolution is used as a fallback. This means{"type":{"const":"core/article"}}still matches variant documents, while{"type":{"const":"core/article#prefab"}}matches only that specific variant.The test adds a "prefab-setting" meta block that is declared only for
core/article#prefaband verifies that it is accepted on the variant but rejected as undeclared on the basecore/article.