This repository was archived by the owner on Sep 14, 2022. It is now read-only.
Add task retry#55
Open
otherpirate wants to merge 2 commits into
Open
Conversation
Member
|
Hi, Thanks for your PR. There are some tasks that don't need to be retried since they are scheduled by API and already have retried logic within. Your PR should ignore those tasks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This code add a feature required in #42
Retry work in all tasks:
NewInstanceTaskRemoveInstanceTaskScaleInstanceTaskRestoreMachineTaskCheckMachineTaskDownloadCertTaskRevokeCertTaskRenewCertsTaskSessionResumptionTaskI added two new environment configurations:
RETRY_COUNTDOWN: Time in seconds between each retryMAX_RETRIES: Max number of retries/attemptsI'm not sure how can I test/run this project, so far I just test in my shell