Skip to content

Stop documenting automatic cookie import and gcloud Gemini login (SBS-933) - #326

Merged
tsouth89 merged 4 commits into
mainfrom
fix/sbs-933-wsl-cookie-docs
Aug 18, 2026
Merged

Stop documenting automatic cookie import and gcloud Gemini login (SBS-933)#326
tsouth89 merged 4 commits into
mainfrom
fix/sbs-933-wsl-cookie-docs

Conversation

@tsouth89

@tsouth89 tsouth89 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • docs/WSL.md told WSL users that Ceiling decrypts Windows browser cookies (DPAPI automatic) and that Gemini signs in with gcloud auth login. Neither is the live path.
  • Cookie extraction is disabled: browser_cookie_header always returns NoCookies (rust/src/providers/mod.rs). Gemini reads Gemini CLI ~/.gemini/oauth_creds.json. The Settings UI says gemini auth login.
  • Same-pass leftovers: dropped the COOKIES.md sentence that said you can change cookie source in Settings (CookieSection is paste/remove only), and the site line that called cookies "browser imports".

A WSL user who follows the Gemini row now runs gemini auth login and gets the file Ceiling actually reads. A user who wants website cookies pastes a header, same as COOKIES.md / DATA_SOURCES.md.

Related issue

SBS-933. Do not merge. Leave Linear In Progress.

Affected areas

  • Documentation
  • Other: site/index.html privacy sentence

Validation

Docs-only PR. Ran rustfmt check, the NoCookies unit test, and worker tests.

Sweep

Fixed WSL.md, COOKIES.md source-picker sentence, and site browser-imports phrase. Left Cursor Automatic (IDE session), DATA_SOURCES DPAPI storage, BUILDING.md module comment, AGENTS.md internals, Vertex AI gcloud ADC, and historical CHANGELOG.

Gaps

Not merged. Linear stays In Progress. Did not rewrite Codex/Claude login flags or delete leftover cookie extraction modules.

Note

Remove documentation of automatic browser cookie import and gcloud auth login for Gemini

  • docs/WSL.md now states Ceiling does not scan browser cookie databases; users must paste a Cookie header or use CLI auth instead.
  • Gemini auth guidance switches from gcloud auth login to installing @google/gemini-cli and running gemini to sign in; Ceiling reads credentials from ~/.gemini/oauth_creds.json.
  • In-app help text (English and Chinese) and the marketing site copy are updated to match, removing references to browser imports and gemini auth login.

Macroscope summarized 881a7f4.

…-933)

WSL.md still described DPAPI browser-cookie import and Gemini via gcloud.
Those are not the live paths: extraction returns NoCookies, and Gemini
reads ~/.gemini/oauth_creds.json from the Gemini CLI.
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tsouth89, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 169bcea7-2457-4036-a4b6-d8b0ca9e7a76

📥 Commits

Reviewing files that changed from the base of the PR and between a6d5433 and 881a7f4.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • docs/COOKIES.md
  • docs/WSL.md
  • rust/src/host/session.rs
  • rust/src/locale/en-US.ftl
  • rust/src/locale/zh-CN.ftl
  • site/index.html

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ceiling 881a7f4 Commit Preview URL

Branch Preview URL
Aug 18 2026, 02:40 AM

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Automated review

New in this pass: 1 issue.

  1. /auth does not switch the Gemini account

    rust/src/locale/en-US.ftl:603 · disposition: fix-if-quick · confidence: high · severity: medium · quick win

    CredsGeminiCliSetupHelp (and the matching WSL.md Gemini recipe plus zh-CN.ftl) tells the user that /auth inside the Gemini CLI switches account. Current Gemini CLI implements /auth as 'Manage authentication': with no args it only opens the auth-method dialog (Google vs API key vs Vertex); the command that drops the current Google session is /auth signout. A user who signs in as the browser's default Google account, then types /auth to change account as Ceiling now says, stays on that account and Ceiling keeps reading the same OAuth session.

    Prompt for AI agents

    In rust/src/locale/en-US.ftl around line 603: Reword the English help, the Chinese string, and the WSL.md Gemini cell so /auth is the sign-in / method dialog and account change is /auth signout then sign in again. Verify against the current code first; if no longer valid, skip with a brief reason. Keep the change minimal.

Resolved since the previous pass: 1.

For coding agents: fix BLOCK and FIX IF QUICK findings now; everything else is tracked or informational; never exceed one CodeRev fix round per PR.

Advisory. Findings generated by grok-subscription and muse-spark-1.2-contributor, each filtered through a 3-vote refutation panel with the changed code in evidence.

Comment thread docs/WSL.md Outdated
The WSL recipe told people to run `gemini auth login`. The Gemini CLI
has no `auth` subcommand: that string is parsed as a query, so it drops
into the normal startup path instead of a login. It authenticates from
inside its own interface, which is what the provider's own "Not logged
in" text already says.

The same wrong command was in the Settings help string for both
languages and in a comment on the credential check, so all four now say
to run `gemini`, with `/auth` named as the way to switch account.
Comment thread rust/src/locale/en-US.ftl Outdated
/auth opens the authentication-method dialog; the command that drops the
current Google session is /auth signout. Telling someone to type /auth
to change account leaves them on the same one.
@tsouth89
tsouth89 merged commit 6303cb9 into main Aug 18, 2026
11 of 12 checks passed
@tsouth89
tsouth89 deleted the fix/sbs-933-wsl-cookie-docs branch August 18, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant