Make sure we clear pings from pings map#31
Open
lixen-wg2 wants to merge 1 commit into
Open
Conversation
tsloughter
reviewed
Oct 28, 2025
Comment on lines
+560
to
+567
| BinPing = h2_frame_ping:to_binary(Payload), | ||
| case maps:get(BinPing, Pings, undefined) of | ||
| undefined -> | ||
| ok; | ||
| {NotifyPid, _} -> | ||
| NotifyPid ! {'PONG', self()} | ||
| end, | ||
| NextPings = maps:remove(Payload, Pings), | ||
| NextPings = maps:remove(BinPing, Pings), |
Owner
There was a problem hiding this comment.
Could this all be done instead with maps:take?
Author
There was a problem hiding this comment.
Yes I guess it makes more sense. I guess I wanted to make the diff small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to call
maps:remove/2with the exact same key that was used to look up the ping, so the correct entry is removed.