Always run DRC against joint traces - #1807
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Benchmark This PRRun benchmarks by commenting on this PR: Comment Everything after Use Any PR whose title contains |
Contributor
Author
|
/benchmark --dataset 23 --pipeline 9 |
Contributor
23 ResultsPrevious main runDataset: srj23
Previous main run details
Dataset: srj23
PR run details
Workflow: View run |
seveibar
marked this pull request as ready for review
July 31, 2026 02:28
Contributor
Author
|
/benchmark-all |
Contributor
Default Benchmark ResultsPrevious main runDataset: dataset01
Previous main run details
Dataset: dataset01
PR run details
Workflow: View run |
Contributor
srj18 ResultsPrevious main runDataset: srj18
Previous main run details
Dataset: srj18
PR run details
Workflow: View run |
Contributor
srj19 ResultsPrevious main runDataset: srj19
Previous main run details
Dataset: srj19
PR run details
Workflow: View run |
Contributor
srj20 ResultsPrevious main runDataset: srj20
Previous main run details
Dataset: srj20
PR run details
Workflow: View run |
Contributor
srj21 ResultsPrevious main runDataset: srj21
Previous main run details
Dataset: srj21
PR run details
Workflow: View run |
Contributor
srj23 ResultsPrevious main runDataset: srj23
Previous main run details
Dataset: srj23
PR run details
Workflow: View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routedTracesso callers cannot mistake it for the complete trace setThe Pipeline9 SRJ23 visual test still verifies solved output and snapshots, but no longer uses the old output-only DRC assertion. Joint DRC now correctly exposes existing collisions in samples 10 and 23 instead of declaring them clean.
Validation
bunx tsc --noEmitbugreport57andbugreport78reproduce unchanged from main