Draft
Fix benchmark dashboard HTML exceeding GitHub's 100 MB push limit#1779
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… embedded runs to DASHBOARD_RUN_LIMIT
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for benchmark history dashboard
Fix benchmark dashboard HTML exceeding GitHub's 100 MB push limit
Jul 28, 2026
Contributor
|
@copilot any other solution? like use large files storage ? |
Contributor
Author
LFS isn't a good fit here for two reasons:
The current fix (slicing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Build benchmark history dashboard" CI job was failing because
benchmark-history.htmlgrew to 156 MB — over GitHub's 100 MB file size limit. The root cause:createBenchmarkHistoryDashboardembedded all historical runs in the inline JSON blob, growing unboundedly, even though the chart already capped rendered points atDASHBOARD_RUN_LIMIT(100).Changes
scripts/benchmark/benchmark-history.ts: Slice embeddedrunstoDASHBOARD_RUN_LIMITbefore serializing into the HTML. Capture the pre-slice count astotalRunCountso the "stored runs" header stat remains accurate.Template JS: Use
dashboardData.totalRunCount ?? dashboardData.runs.lengthfor the "stored runs" display so the header reflects the true historical total, not just the capped window.tests/benchmark-history.test.ts: Update assertions for the 101-run fixture —runsin the payload is now capped at 100, andtotalRunCountcarries the true count of 101.