fix: align VCNL4040 and Qwiic connector 3D models with footprints - #314
Open
anil08607 wants to merge 3 commits into
Open
fix: align VCNL4040 and Qwiic connector 3D models with footprints#314anil08607 wants to merge 3 commits into
anil08607 wants to merge 3 commits into
Conversation
mohan-bee
requested changes
Jul 26, 2026
mohan-bee
left a comment
mohan-bee
left a comment
Contributor
There was a problem hiding this comment.
Not a right fix ig, this is import issue if the component imported from jlcpcb
Contributor
Author
|
@mohan-bee Right now, I'm importing them from JLCPCB. Could you check them? |
Contributor
|
tests failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The VCNL4040 sensor and Qwiic connector 3D models were not aligned with their footprint pads, making the board’s 3D preview inaccurate. Correct placement is important for visually validating the PCB layout and component assembly.