Fix RS232 breakout routing, jumper state, and DE9 3D alignment - #306
Open
rushabhcodes wants to merge 1 commit into
Open
Fix RS232 breakout routing, jumper state, and DE9 3D alignment#306rushabhcodes wants to merge 1 commit into
rushabhcodes wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShiboSoftwareDev
left a comment
ShiboSoftwareDev
left a comment
Contributor
There was a problem hiding this comment.
a lot of regressions, maybe we should fix the issues first?
if we merge I'm sure most of these issues will go overlooked
Contributor
Author
I think most of the 3d issues are due to these explicit position defined in the imported components |
Contributor
oh maybe issue from the converter ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix rendering and board-generation regressions affecting the SparkFun RS232 Breakout with the updated tscircuit toolchain.
Root cause
The board still used explicit autorouter and solder-jumper settings from the previous toolchain behavior, while the imported DE9 connector used legacy CAD model metadata. With the newer renderer, this produced outdated routing, jumper, footprint, and 3D output.
Changes
Regression coverage
The updated snapshots capture the rendering differences introduced by the newer toolchain and verify the corrected output across:
Validation
bunx biome format boards/SparkFun-RS232-Breakout/SparkFun-RS232-Breakout.circuit.tsx boards/SparkFun-RS232-Breakout/imports/DS1037_09FNAKT74_0CC.tsx package.jsonbun run tsci-build— 105 circuits passed; build completed successfully