Revert "Bun install proper deps" - #4242
Merged
Merged
Conversation
This reverts the dependency classification and workflow changes from commit 8ac7c14 while preserving later package version updates.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
marked this pull request as ready for review
July 31, 2026 03:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4205 while preserving the later package version and
@tscircuit/eval@^0.0.1102updates.What changed
devDependencies.@tscircuit/eval,@tscircuit/solver-utils, anddebug.bun.lockfrom the reverted manifest.Why
#4205 caused
@tscircuit/runframe@0.0.2322to publishcircuit-json-to-lbrnas a runtime dependency. That package installsmanifold-3d, which fails the published-package dependency guard in tscircuit/tscircuit#4182.Impact
A release from this change will stop runframe from introducing
manifold-3dinto downstream package installations.Validation
bun run format:checkbun run buildnode_modules/manifold-3d