feat: dynamically load export converters from jsdelivr CDN - #4014
feat: dynamically load export converters from jsdelivr CDN#4014mitre88 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bf20cce1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d37d5e9 to
55ce2cd
Compare
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
55ce2cd to
0af29ec
Compare
0af29ec to
e23f653
Compare
e23f653 to
f87e45f
Compare
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
f87e45f to
cd6785b
Compare
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
1 participant
Replaces stale/auto-closed PRs #3558, #3809, and #3947 for tscircuit/tscircuit#1539. GitHub would not reopen #3947, so this branch was freshly rebased on current main.
This keeps export converter packages out of the runframe bundle and loads pinned jsdelivr ESM modules on demand for gerber, BOM CSV, PnP CSV, KiCad, GLB, STEP, and LBRN export paths. It preserves current main changes and regenerates the Bun lockfile after removing the converter dependencies.
Follow-up d37d5e9 addresses review feedback by keeping the GLTF preload optional for STEP exports, so a blocked GLTF CDN does not prevent board-only STEP generation.
Validation on head d37d5e9: