-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add fanout autorouter phase props #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,18 @@ test("autorouting phase accepts autorouter and phase index", () => { | |
| expect(parsed.phaseIndex).toBe(1) | ||
| }) | ||
|
|
||
| test("autorouting phase accepts per-bus fanout directions", () => { | ||
| const raw = { | ||
| autorouter: "fanout", | ||
| busFanoutDirections: { | ||
| DATA: "top_right", | ||
| CONTROL: { direction: "center_left" }, | ||
| }, | ||
| } satisfies AutoroutingPhaseProps | ||
|
|
||
| expect(autoroutingPhaseProps.parse(raw)).toEqual(raw) | ||
| }) | ||
|
Comment on lines
+33
to
+43
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A Spotted by Graphite (based on custom rule: Custom rule) |
||
|
|
||
| test("autorouting phase accepts a single connection", () => { | ||
| const raw: AutoroutingPhaseProps = { | ||
| phaseIndex: 2, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
*.test.tsfile may have AT MOST onetest(...)call. This file already contained at least onetest(...)before this PR, and the newtest("supports fanout presets", ...)block adds another. The file should be split into multiple numbered files, e.g.autorouter1.test.ts,autorouter2.test.ts, etc., each containing exactly onetest(...)call.Spotted by Graphite (based on custom rule: Custom rule)

Is this helpful? React 👍 or 👎 to let us know.