-
Notifications
You must be signed in to change notification settings - Fork 44
Include generated docs in local circuit prompt #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
momenbuilds
wants to merge
2
commits into
tscircuit:main
Choose a base branch
from
momenbuilds:codex/generated-docs-prompt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| import { afterEach, beforeEach, expect, test } from "bun:test" | ||
| import { | ||
| createLocalCircuitPrompt, | ||
| resetGeneratedDocsCacheForTests, | ||
| } from "../lib/prompt-templates/create-local-circuit-prompt" | ||
|
|
||
| const originalFetch = globalThis.fetch | ||
|
|
||
| beforeEach(() => { | ||
| resetGeneratedDocsCacheForTests() | ||
| }) | ||
|
|
||
| afterEach(() => { | ||
| globalThis.fetch = originalFetch | ||
| resetGeneratedDocsCacheForTests() | ||
| }) | ||
|
|
||
| function mockFetchWithGeneratedDocs( | ||
| generatedDocsResponse: string | Error | Response, | ||
| ) { | ||
| const calls: string[] = [] | ||
|
|
||
| globalThis.fetch = (async (input: RequestInfo | URL) => { | ||
| const url = input.toString() | ||
| calls.push(url) | ||
|
|
||
| if (url === "https://docs.tscircuit.com/ai.txt") { | ||
| if (generatedDocsResponse instanceof Error) { | ||
| throw generatedDocsResponse | ||
| } | ||
|
|
||
| if (generatedDocsResponse instanceof Response) { | ||
| return generatedDocsResponse | ||
| } | ||
|
|
||
| return new Response(generatedDocsResponse) | ||
| } | ||
|
|
||
| if ( | ||
| url === | ||
| "https://raw.githubusercontent.com/tscircuit/props/main/generated/COMPONENT_TYPES.md" | ||
| ) { | ||
| return new Response('# Component Types\n\n<led name="LED1" />') | ||
| } | ||
|
|
||
| return new Response("not found", { status: 404, statusText: "Not Found" }) | ||
| }) as typeof fetch | ||
|
|
||
| return calls | ||
| } | ||
|
|
||
| test("includes generated tscircuit docs when ai.txt is available", async () => { | ||
|
|
||
| mockFetchWithGeneratedDocs( | ||
| "Use net aliases for shared rails.\nPrefer explicit footprints.", | ||
| ) | ||
|
|
||
| const prompt = await createLocalCircuitPrompt() | ||
|
|
||
| expect(prompt).toContain("### Generated tscircuit docs") | ||
| expect(prompt).toContain("Use net aliases for shared rails.") | ||
| expect(prompt).toContain("Prefer explicit footprints.") | ||
| expect(prompt).toContain('<led name="LED1" />') | ||
| }) | ||
|
|
||
| test("continues without generated docs when ai.txt cannot be loaded", async () => { | ||
|
|
||
| mockFetchWithGeneratedDocs(new Error("docs unavailable")) | ||
|
|
||
| const prompt = await createLocalCircuitPrompt() | ||
|
|
||
| expect(prompt).not.toContain("### Generated tscircuit docs") | ||
| expect(prompt).toContain('<led name="LED1" />') | ||
| expect(prompt).toContain("YOU MUST ABIDE BY THE RULES IN THE RULES SECTION") | ||
| }) | ||
|
|
||
| test("continues without generated docs when ai.txt returns a non-2xx response", async () => { | ||
| mockFetchWithGeneratedDocs( | ||
| new Response("missing", { status: 404, statusText: "Not Found" }), | ||
| ) | ||
|
|
||
| const prompt = await createLocalCircuitPrompt() | ||
|
|
||
| expect(prompt).not.toContain("### Generated tscircuit docs") | ||
| expect(prompt).toContain('<led name="LED1" />') | ||
| }) | ||
|
|
||
| test("caches generated docs across prompt creation calls", async () => { | ||
|
|
||
| const calls = mockFetchWithGeneratedDocs("Generated docs body") | ||
|
|
||
| await createLocalCircuitPrompt() | ||
| await createLocalCircuitPrompt() | ||
|
|
||
| const generatedDocsCalls = calls.filter( | ||
| (url) => url === "https://docs.tscircuit.com/ai.txt", | ||
| ) | ||
| expect(generatedDocsCalls).toHaveLength(1) | ||
| }) | ||
|
|
||
| test("retries generated docs fetch after a transient failure", async () => { | ||
| const calls: string[] = [] | ||
| let generatedDocsAttempts = 0 | ||
|
|
||
| globalThis.fetch = (async (input: RequestInfo | URL) => { | ||
| const url = input.toString() | ||
| calls.push(url) | ||
|
|
||
| if (url === "https://docs.tscircuit.com/ai.txt") { | ||
| generatedDocsAttempts += 1 | ||
| if (generatedDocsAttempts === 1) { | ||
| throw new Error("temporary outage") | ||
| } | ||
|
|
||
| return new Response("Recovered generated docs") | ||
| } | ||
|
|
||
| if ( | ||
| url === | ||
| "https://raw.githubusercontent.com/tscircuit/props/main/generated/COMPONENT_TYPES.md" | ||
| ) { | ||
| return new Response('# Component Types\n\n<led name="LED1" />') | ||
| } | ||
|
|
||
| return new Response("not found", { status: 404, statusText: "Not Found" }) | ||
| }) as typeof fetch | ||
|
|
||
| const promptWithoutGeneratedDocs = await createLocalCircuitPrompt() | ||
| const promptWithGeneratedDocs = await createLocalCircuitPrompt() | ||
|
|
||
| expect(promptWithoutGeneratedDocs).not.toContain( | ||
| "### Generated tscircuit docs", | ||
| ) | ||
| expect(promptWithGeneratedDocs).toContain("Recovered generated docs") | ||
| expect( | ||
| calls.filter((url) => url === "https://docs.tscircuit.com/ai.txt"), | ||
| ).toHaveLength(2) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchGeneratedDocscaches the promise result even when the fetch fails, because the rejection is converted to""and stored ingeneratedDocsPromise. Ifhttps://docs.tscircuit.com/ai.txthas a temporary outage on the first call, every later prompt in that process will permanently omit generated docs with no retry path, which defeats the new docs-inclusion behavior for long-lived workers.Useful? React with 👍 / 👎.