Add all JST footprint models - #314
Draft
seveibar wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSTPH2mm,JSTSH1mm, andJSTSmdparametric components alongside the existing ZH modeljstN/jstN_ph,jstN_sh,jstN_zh, andjstN_smdthroughFootprinter3dWhy
Footprinter3dpreviously returned a JST model only when the parsed footprint had the ZH flag. Generic JST (which defaults to PH), explicit PH, SH, and the new generic SMD variant therefore produced no JSCAD geometries, causing downstream GLB generation such as modelcdn to return 404.Impact
Every JST family exposed by footprinter now produces a distinct model with matching mounting style and pad locations. Existing ZH behavior remains supported, while modelcdn consumers can generate PH, SH, ZH, and generic SMD assets from their normal footprinter strings.
Validation
bun run buildbun test(89 tests pass)bunx tsc --noEmitbun run format:checkjst2,jst2_ph,jst2_sh,jst2_zh, andjst2_smdNote: the existing
bun run test:vanillascript references a missingtests/vanilla-smoke.mjsfile onmain; the checked-in vanilla tests pass throughbun test.