Skip to content

Add all JST footprint models - #314

Draft
seveibar wants to merge 1 commit into
mainfrom
agent/add-all-jst-models
Draft

Add all JST footprint models#314
seveibar wants to merge 1 commit into
mainfrom
agent/add-all-jst-models

Conversation

@seveibar

Copy link
Copy Markdown
Contributor

Summary

  • add public JSTPH2mm, JSTSH1mm, and JSTSmd parametric components alongside the existing ZH model
  • route jstN/jstN_ph, jstN_sh, jstN_zh, and jstN_smd through Footprinter3d
  • pass generic SMD signal and mounting-pad parameters through to the model
  • update footprinter to 0.0.401 for the new generic JST SMD definition
  • add documentation, a Cosmos family example, vanilla-path regression tests, and visual golden snapshots for every variant

Why

Footprinter3d previously returned a JST model only when the parsed footprint had the ZH flag. Generic JST (which defaults to PH), explicit PH, SH, and the new generic SMD variant therefore produced no JSCAD geometries, causing downstream GLB generation such as modelcdn to return 404.

Impact

Every JST family exposed by footprinter now produces a distinct model with matching mounting style and pad locations. Existing ZH behavior remains supported, while modelcdn consumers can generate PH, SH, ZH, and generic SMD assets from their normal footprinter strings.

Validation

  • bun run build
  • bun test (89 tests pass)
  • bunx tsc --noEmit
  • bun run format:check
  • production-style GLB conversion for jst2, jst2_ph, jst2_sh, jst2_zh, and jst2_smd

Note: the existing bun run test:vanilla script references a missing tests/vanilla-smoke.mjs file on main; the checked-in vanilla tests pass through bun test.

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
jscad-electronics Ready Ready Preview, Comment Jul 27, 2026 11:38pm

Request Review

@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant