add LED5050 3D model - #312
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
marked this pull request as ready for review
July 26, 2026 18:43
rushabhcodes
requested review from
ShiboSoftwareDev,
seveibar and
techmannih
as code owners
July 26, 2026 18:43
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
imrishabh18
reviewed
Jul 26, 2026
imrishabh18
left a comment
imrishabh18
left a comment
Member
There was a problem hiding this comment.
Add the snapshot the model which you're referencing
seveibar
approved these changes
Jul 29, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Led5050JSCAD model with a white tapered package, yellow phosphor surface, six aligned contacts, and a shallow pin-1 corner recessled5050footprinter function, including_color(...)overrides@tscircuit/footprinterto the version that supportsled5050Ref
Why
led5050footprints previously had no matching 3D package model, so footprint previews could only render their pads.Impact
Consumers using the
led5050footprint now receive a dimensionally matched 5.4 × 5.0 × 1.55 mm 3D model with contacts aligned to the footprint rows.Validation
bun run format:checkbunx tsc --noEmitbun run buildbun test— 75 passed, 0 failed