Add dimensionally accurate crystal4 3D model support - #311
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
marked this pull request as ready for review
July 26, 2026 10:25
rushabhcodes
requested review from
ShiboSoftwareDev,
seveibar and
techmannih
as code owners
July 26, 2026 10:25
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
seveibar
approved these changes
Jul 29, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first dedicated 3D model implementation for
crystal4footprints.The new model represents a 3.2 × 2.5 × 0.7 mm metal-can crystal package and derives its geometry from footprinter parameters.
Visual Coverage
Adds a PNG snapshot test for
crystal4to validate the complete rendered package and protect the new model from visual regressions.Validation
bun test— 73 tests passingbun test tests/snapshots/crystal4.test.tsbun run buildbunx biome check lib/Crystal.tsx