Add PDIP-8 footprint alias#626
Open
DrOetker747 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #371
Adds PDIP string normalization for the existing DIP footprint generator so common package names such as
PDIP-8,pdip8, and parameterized forms likepdip8_w7.62mmresolve through the same implementation asdip8.This keeps the footprint geometry in one place instead of duplicating the DIP generator for the plastic DIP naming variant.
Verification run locally:
npm exec -- biome check src/footprinter.ts tests/dip.test.tsnpm run buildPDIP-8andpdip8produce the same JSON asdip8git diff --checkNotes:
bun test, butbunis not installed in this environment, so I could not run the Bun test suite directly.npm exec -- tsc --noEmitcurrently reports unrelated pre-existing type errors in several test files involving circuit-json union types;npm run buildsucceeds for the package source and declarations.