Fix static proxy responses forcing attachment downloads - #140
Open
vagdotdev wants to merge 1 commit into
Open
Conversation
Author
|
/claim #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveFileProxydownload behavior as attachment by defaultContent-Disposition: attachment/files/static/...stays inline for proxied filesWhy
Direct
/files/static/...responses intentionally do not setContent-Disposition, but proxied static files reused the download resolver and forcedattachment. That makes proxied static assets behave like downloads instead of inline static content.Validation
bun test tests/routes/file-proxy02.test.ts tests/routes/file-proxy03.test.tsbun testbunx tsc --noEmitbun run format:checkbun run buildgit diff --check/claim #5