[codex] preserve HTTP proxy path delimiters - #131
Open
guiwenlingmu962-bot wants to merge 1 commit into
Open
Conversation
guiwenlingmu962-bot
marked this pull request as ready for review
June 28, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?, and#as encoded path dataRoot cause and impact
The previous string concatenation treated
?and#in a file path as URL query and fragment delimiters. It could also append the separator after a proxy target's existing query string. As a result, valid proxied file names could fetch the wrong URL or return 404.The new helper appends to
URL.pathname, which percent-encodes path delimiters while leaving the configured query string intact.Validation
bun test— 31 passedbun test tests/routes/file-proxy03.test.ts --timeout 50000— 6 passedbun x tsc --noEmit --pretty falsebun x biome format lib/utils/resolve-file-proxy.ts tests/routes/file-proxy03.test.tsgit diff --checkbun run buildremains blocked on Windows by the existing Winterspec absolute-path backslash parsing issue; the tests and TypeScript check pass./claim #5