Skip to content

fix: encode international download filenames - #130

Open
caaeco wants to merge 1 commit into
tscircuit:mainfrom
caaeco:bounty-5-content-disposition
Open

fix: encode international download filenames#130
caaeco wants to merge 1 commit into
tscircuit:mainfrom
caaeco:bounty-5-content-disposition

Conversation

@caaeco

@caaeco caaeco commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • centralize attachment Content-Disposition generation for all download paths
  • preserve the existing header for safe ASCII filenames
  • add a sanitized ASCII fallback plus RFC 5987 filename* for international or quoted filenames
  • apply the header helper to database, disk-proxy, and HTTP-proxy downloads
  • add unit and route regression coverage

Validation

  • bun test - 32 passed, 0 failed
  • tsc --noEmit - passed
  • targeted Biome formatting check - passed

Note: the local Winterspec bundle command currently fails on this Windows workspace because its generated stdin contains unescaped backslash paths; the test and typecheck suites pass and CI can validate the Linux build.

/claim #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant