add regression tests for POLYGON pad parts C2879853, C5360621, C9900014805 - #395
Open
Swately wants to merge 2 commits into
Open
add regression tests for POLYGON pad parts C2879853, C5360621, C9900014805#395Swately wants to merge 2 commits into
Swately wants to merge 2 commits into
Conversation
…rcuit#218 tscircuit#240) Both parts have POLYGON-shaped SMT pads. The fix for the PadSchema enum was landed in tscircuit#289; this commit adds the missing regression tests so the fix is covered going forward.
…ix ref tscircuit#289) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The POLYGON pad fix landed in #289, but the parts from the open issues never got regression tests, so the issues stayed open.
This adds the raw fixtures + snapshot tests for the three reported parts:
All three used to fail with
Invalid enum value. Expected 'RECT' | 'ELLIPSE' | 'OVAL', received 'POLYGON'and now convert correctly. Full suite: 107 pass / 0 fail.Note: C2879853 and C9900014805 share identical pad geometry (same footprint), so their 3d snapshots are byte-identical — checked, not an accident.
Fixes #218
Fixes #239
Fixes #240